Error in simple 7 segment library

hi arduino forums,

i'm having slice of trouble making library work fitting.

i have dusted code on , on see if there have missed, when try compare notes arduino references code, have hard time understanding references mean.
it might fault i'm stuck none less..

here's header code:

code: [select]

/*
this header dedicated my
7 segment counter library arduino uno

erik klint, mercantec skp
*/
#ifndef skpssc_h
#define skpssc_h

const int dpa = 0; // name output pins: 0-3 + 8
const int dpb = 1;
const int dpc = 2;
const int dpd = 3;
const int pwr = 8; // transistor base enabler pin 8

void setup() // set pins output
{
pinmode(dpa, output);
pinmode(dpb, output);
pinmode(dpc, output);
pinmode(dpd, output);
pinmode(pwr, output);
}

void loop()
{
    zero();
    one();
    two();
    three();
    four();
    five();
    six();
    seven();
    eight();
    nine();
}
void zero() // show 0 on 7 segment
{
digitalwrite(pwr, high);
digitalwrite(dpa, low);
digitalwrite(dpb, low);
digitalwrite(dpc, low);
digitalwrite(dpd, low);
delay(1000);
    digitalwrite(pwr, low);
}
void one() // show 1 on 7 segment
{
digitalwrite(pwr, high);
digitalwrite(dpa, high);
digitalwrite(dpb, low);
digitalwrite(dpc, low);
digitalwrite(dpd, low);
delay(1000);
    digitalwrite(pwr, low);
}
void two() // show 2 on 7 segment
{
digitalwrite(pwr, high);
digitalwrite(dpa, low);
digitalwrite(dpb, high);
digitalwrite(dpc, low);
digitalwrite(dpd, low);
delay(1000);
    digitalwrite(pwr, low);
}
void three() // show 3 on 7 segment
{
digitalwrite(pwr, high);
digitalwrite(dpa, high);
digitalwrite(dpb, high);
digitalwrite(dpc, low);
digitalwrite(dpd, low);
delay(1000);
    digitalwrite(pwr, low);
}
void four() // show 4 on 7 segment
{
digitalwrite(pwr, high);
digitalwrite(dpa, low);
digitalwrite(dpb, low);
digitalwrite(dpc, high);
digitalwrite(dpd, low);
delay(1000);
    digitalwrite(pwr, low);
}
void five() // show 5 on 7 segment
{
digitalwrite(pwr, high);
digitalwrite(dpa, high);
digitalwrite(dpb, low);
digitalwrite(dpc, high);
digitalwrite(dpd, low);
delay(1000);
    digitalwrite(pwr, low);
}
void six() // show 6 on 7 segment
{
digitalwrite(pwr, high);
digitalwrite(dpa, low);
digitalwrite(dpb, high);
digitalwrite(dpc, high);
digitalwrite(dpd, low);
delay(1000);
    digitalwrite(pwr, low);
}
void seven() // show 7 on 7 segment
{
digitalwrite(pwr, high);
digitalwrite(dpa, high);
digitalwrite(dpb, high);
digitalwrite(dpc, high);
digitalwrite(dpd, low);
delay(1000);
    digitalwrite(pwr, low);
}
void eight() // show 8 on 7 segment
{
digitalwrite(pwr, high);
digitalwrite(dpa, low);
digitalwrite(dpb, low);
digitalwrite(dpc, low);
digitalwrite(dpd, high);
delay(1000);
    digitalwrite(pwr, low);
}
void nine() // show 9 on 7 segment
{
digitalwrite(pwr, high);
digitalwrite(dpa, high);
digitalwrite(dpb, low);
digitalwrite(dpc, low);
digitalwrite(dpd, high);
delay(1000);
    digitalwrite(pwr, low);
}

class skpssc
{
  public:
    skpssc(const int dpa, const int dpb, const int dpc, const int dpd, const int pwr);
    void zero();
    void one();
    void two();
    void three();
    void four();
    void five();
    void six();
    void seven();
    void eight();
    void nine();
  private:
    const int _pwr;
    const int _dpa;
    const int _dpb;
    const int _dpc;
    const int _dpd;
};
#endif

and here's .cpp:

code: [select]

/* begin doc */
#include "skpssc.h"

skpssc::skpssc(const int pwr, const int dpa, const int dpb, const int dpc, const int dpd)
{
  pinmode(pwr, output);
  pinmode(dpa, output);
  pinmode(dpb, output);
  pinmode(dpc, output);
  pinmode(dpd, output);
  _pwr = pwr;
  _dpa = dpa;
  _dpb = dpb;
  _dpc = dpc;
  _dpd = dpd;
}
void skpssc::zero()
{
digitalwrite(_pwr, high);
digitalwrite(_dpa, low);
digitalwrite(_dpb, low);
digitalwrite(_dpc, low);
digitalwrite(_dpd, low);
delay(500);
    digitalwrite(_pwr, low);
}
void skpssc::one()
{
digitalwrite(_pwr, high);
digitalwrite(_dpb, high);
digitalwrite(_dpb, low);
digitalwrite(_dpc, low);
digitalwrite(_dpd, low);
    delay(500);
digitalwrite(_pwr, low);
}
void skpssc::two()
{
digitalwrite(_pwr, high);
digitalwrite(_dpa, low);
digitalwrite(_dpb, high);
digitalwrite(_dpc, low);
digitalwrite(_dpd, low);
    delay(500);
digitalwrite(_pwr, low);
}
void skpssc::three()
{
digitalwrite(_pwr, high);
digitalwrite(_dpa, high);
digitalwrite(_dpb, high);
digitalwrite(_dpc, low);
digitalwrite(_dpd, low);
delay(500);
    digitalwrite(_pwr, low);
}
void skpssc::four()
{
digitalwrite(_pwr, high);
digitalwrite(_dpa, low);
digitalwrite(_dpb, low);
digitalwrite(_dpc, high);
digitalwrite(_dpd, low);
    delay(500);
digitalwrite(_pwr, low);
}
void skpssc::five()
{
digitalwrite(_pwr, high);
digitalwrite(_dpa, high);
digitalwrite(_dpb, low);
digitalwrite(_dpc, high);
digitalwrite(_dpd, low);
    delay(500);
digitalwrite(_pwr, low);
}
void skpssc::six()
{
digitalwrite(_pwr, high);
digitalwrite(_dpa, low);
digitalwrite(_dpb, high);
digitalwrite(_dpc, high);
digitalwrite(_dpd, low);
    delay(500);
digitalwrite(_pwr, low);
}
void skpssc::seven()
{
digitalwrite(_pwr, high);
digitalwrite(_dpa, high);
digitalwrite(_dpb, high);
digitalwrite(_dpc, high);
digitalwrite(_dpd, low);
    delay(500);
digitalwrite(_pwr, low);
}
void skpssc::eight()
{
digitalwrite(_pwr, high);
digitalwrite(_dpa, low);
digitalwrite(_dpb, low);
digitalwrite(_dpc, low);
digitalwrite(_dpd, low);
    delay(500);
digitalwrite(_pwr, high);
}
void skpssc::nine()
{
digitalwrite(_pwr, high);
digitalwrite(_dpa, high);
digitalwrite(_dpb, low);
digitalwrite(_dpc, low);
digitalwrite(_dpd, high);
    delay(500);
digitalwrite(_pwr, low);
}

i error "type not defined" when try include lib in sketch.

i have no idea go here still green in programming.

thanks before hand!

you've got many problems. first, have setup() , loop() defined in header file. that's nonsense.

second, have stuff diddles hardware (pinmode() calls) in constructor, called before hardware ready diddled with.

third setup() , constructor diddling same hardware. not idea.

fourth, "type not defined" follows type not defined. didn't bother telling problem is.

Arduino Forum > Using Arduino > Programming Questions > Error in simple 7 segment library

arduino