Beginner project "Traffic Lights" code check.

hello

i started arduino few days ago . first project "traffic lights" works .
i wanted take next level adding button pedestrians wish cross road .
this having troubles . maby can me looking @ code .

code: [select]

int red = 13;
int yellow = 12;
int green = 11;
int redv = 10;
int greenv = 9;
int buttonv =2;

void setup(){
pinmode(red,output);
pinmode(yellow,output);
pinmode(green,output);
pinmode(redv,output);
pinmode(greenv,output);
pinmode(buttonv,input);
}

void loop(){
changelights();
delay(500);
}

void changelights(){
  int knop = digitalread(buttonv);
  if (knop == low){
digitalwrite(redv,high);
delay(500);
digitalwrite(green,high);
digitalwrite(greenv,low);
delay(3000);
digitalwrite(green,low);
digitalwrite(yellow,high);
delay(2000);


digitalwrite(green,low);
digitalwrite(yellow,low);
digitalwrite(red,high);
delay(500);
digitalwrite(redv,low);
digitalwrite(greenv,high);
delay(3000);
digitalwrite(redv,high);
digitalwrite(greenv,low);
delay(500);


digitalwrite(yellow,low);
digitalwrite(red,low);
digitalwrite(green,high);
  }
 
else {
  digitalwrite(green,high);
  digitalwrite(redv,high);
  digitalwrite(greenv,low);
  delay(1000);
  digitalwrite(redv,high);
  digitalwrite(green,low);
  digitalwrite(yellow,high);
  digitalwrite(greenv,low);
  delay(2000);
  digitalwrite(redv,low);
  digitalwrite(yellow,low);
  digitalwrite(red,high);
  digitalwrite(greenv,high);
  delay(5000);

}
}

thank !

quote from: xorviver on jul 09, 2014, 06:20 pm

this having troubles

what troubles?

Arduino Forum > Using Arduino > Project Guidance > Beginner project "Traffic Lights" code check.

arduino